NXP-29129: refresh aws s3 token #917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View issue in JIRA: NXP-29129: Web UI Upload Issues |
nelsonsilva
force-pushed
the
fix-NXP-29129-s3-creds
branch
from
c04872b
to
c1d52e5
Compare
|
⭐ PR built and available in a preview environment nuxeo-nuxeo-web-ui-pr-917 here |
RSalem07
approved these changes
May 20, 2020
nelsonsilva
commented
May 20, 2020
| credentials.refresh = (cb) => | ||
| this._resource(`upload/${this.batchId}/refreshToken`) | ||
| .post() | ||
| .then((response) => { |
There was a problem hiding this comment.
I'll add a catch(cb) before merging this
Gabez0r
reviewed
May 20, 2020
| options.awsSessionToken, | ||
| ); | ||
| credentials.expireTime = new Date(options.expiration); | ||
| credentials.refresh = (cb) => |
There was a problem hiding this comment.
When will this refresh be called? Do we need to implement needsRefresh as well?
There was a problem hiding this comment.
No, default needsRefresh implementaton works with the expiration info, see https://github.com/aws/aws-sdk-js/blob/master/lib/credentials.js#L95
BoboTiG
approved these changes
May 20, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.