NXP-28802: Make fixed part of document history pp configurable (10.10) #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efge
reviewed
Apr 9, 2020
| pageProvider.setSearchDocumentModel(searchDoc); | ||
| assertEquals(1, pageProvider.getCurrentPage().size()); | ||
|
|
||
| //test with proxy to check that the doc uuid is correctly set in the fixed part |
There was a problem hiding this comment.
This comment and the one above has the correct space after // on master.
There was a problem hiding this comment.
Thanks for catching it.
efge
changed the title
|
@kevinleturc do you mean squashed? |
|
This is the same thing, squash keeps the commit message whereas fixup doesn't. You can use one or the other. Thanks |
efge
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.