NXP-28726: bump woodstox library version #4097
Conversation
|
View issue in JIRA: NXP-28726: Fix woodstox library version used by add nuxeo-management-rest-api 1.0.0 |
ghost
requested review from
bdelbosc and
kevinleturc
and removed request for
a team
NourNuxeo
force-pushed
the
fix-NXP-28726-bump-woodstox-library-version
branch
3 times, most recently
from
62dd690
to
9a0ac6e
Compare
NourNuxeo
force-pushed
the
fix-NXP-28726-bump-woodstox-library-version
branch
2 times, most recently
from
b7d76e2
to
776f2f1
Compare
ftests/nuxeo-server-tests/pom.xml
Outdated
|
|
||
| <!-- excluded from chemistry-opencmis-commons-impl for groupId & version issues --> | ||
| <dependency> | ||
| <groupId>com.fasterxml.woodstox</groupId> | ||
| <artifactId>woodstox-core</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
There was a problem hiding this comment.
Added this dependency to fix some failing test org.nuxeo.ftest.server.ITOAuth2Test(nuxeo-server-tests).testAuthorizationOnCMIS:
https://qa.nuxeo.org/jenkins/view/TestAndPush/job/TestAndPush/job/ondemand-testandpush-nalkotob/146/testReport/junit/org.nuxeo.ftest.server/ITOAuth2Test(nuxeo-server-tests)/testAuthorizationOnCMIS/
ftests/nuxeo-server-tests/pom.xml
Outdated
| <!-- excluded from chemistry-opencmis-commons-impl for groupId & version issues --> | ||
| <dependency> | ||
| <groupId>com.fasterxml.woodstox</groupId> | ||
| <artifactId>woodstox-core</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
I'm not sure this is really needed, the dependency added to nuxeo-opencmis-impl should be enough (and you don't have it on the 10.10 PR 😃 )
It should be tested again without it.
There was a problem hiding this comment.
The list of failing tests was not exactly the same for Master, there is one extra test that was failing because it was missing the dependency (so I scoped it accordingly):
There was a problem hiding this comment.
The server is returning 500, I don't see why adding a test dependency to the server ftests would fix the issue... 🤔
Is it possible to relaunch it w/o the dep so that we can see the server logs? :)
There was a problem hiding this comment.
Sure
I hope I can pass through the randoms !
(but about the 500 error, since it's a test involving CMIS on a server which fails, I'm not surprized to have a 500 though)
There was a problem hiding this comment.
The error is server side, so it's related to jars in the server. Here you are adding a dependency to a functional tests module, it won't end up in the server.
Adding the dependency to the nuxeo-opencmis-impl module should be enough as this module (and its dependencies) will be deployed in the server.
There was a problem hiding this comment.
NourNuxeo
force-pushed
the
fix-NXP-28726-bump-woodstox-library-version
branch
from
776f2f1
to
ab9e8b8
Compare
NourNuxeo
force-pushed
the
fix-NXP-28726-bump-woodstox-library-version
branch
from
ab9e8b8
to
73a2475
Compare
|
Ok so in the end the code is the same as for 10.10 #4096 |
No description provided.