Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXP-29772: Fix list/grid view display when POST method is used by page providers #4398

Conversation

tmartins
Copy link
Member

Manual PR after T&P passed and created #4397 but it contains the fix for 2 tickets, and the second one is not clean

@nuxeojenkins
Copy link
Collaborator

View issue in JIRA: NXP-29772: Fix list/grid view display when POST method is used by page providers

@tmartins tmartins force-pushed the fix-NXP-29772-Fix-view-display-when-POST-method-is-used-by-page-providers-10.10 branch from aa85b36 to a262be8 Compare October 19, 2020 19:34
@loopingz loopingz self-requested a review October 19, 2020 19:54
Copy link
Contributor

@loopingz loopingz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems weird to me to have both currentOffset and currentPageIndex but it is more on the underlying layer than this current PR

@efge
Copy link
Member

efge commented Oct 19, 2020

It seems weird to me to have both currentOffset and currentPageIndex but it is more on the underlying layer than this current PR

Yes the PageProvider architecture is really old and messy.

@tmartins tmartins merged commit 601f824 into 10.10 Oct 19, 2020
@tmartins tmartins deleted the fix-NXP-29772-Fix-view-display-when-POST-method-is-used-by-page-providers-10.10 branch October 19, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants