fix-NXP-30572-perms-admin-10.10 #4927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View issue in JIRA: NXP-30572: Fix permission filtering for administrators |
kevinleturc
approved these changes
Aug 26, 2021
ataillefer
reviewed
Aug 30, 2021
| @@ -268,6 +292,7 @@ public void setUp() { | |||
| addPermission(session.getRootDocument(), JOHN, REMOVE_CHILDREN); | |||
| folder = session.createDocumentModel("/", "myFolder", "Folder"); | |||
| folder = session.createDocument(folder); | |||
| blockPermissionInheritance(folder); | |||
There was a problem hiding this comment.
to verify that Administrator does not get its permissions from the ACP, but from the fact that it's a admin user
| @@ -235,6 +250,15 @@ public void iCanRemoveRetainedDocInGovernance() throws LoginException { | |||
| public void iDoNotHaveRemovePermissionInCompliance() throws LoginException { | |||
| assertFalse(session.hasPermission(documentModelUnderLegalHold.getRef(), REMOVE)); | |||
| assertFalse(session.hasPermission(documentModelUnderRetention.getRef(), REMOVE)); | |||
| // check that other permissions are still granted to admin | |||
| List<String> allPermissions = new ArrayList<String>( | |||
There was a problem hiding this comment.
Suggested change
| List<String> allPermissions = new ArrayList<String>( | |
| List<String> allPermissions = new ArrayList<>( |
guirenard
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR created from https://qa2.nuxeo.org/jenkins/job/TestAndPush/job/ondemand-testandpush-tmartins-10.10/52/