Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update options.md documentation to reflect current #135

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Update options.md documentation to reflect current #135

merged 1 commit into from
Apr 11, 2018

Conversation

benmccallum
Copy link
Contributor

@benmccallum benmccallum commented Apr 11, 2018

Addresses issue: #122

@benmccallum
Copy link
Contributor Author

Hey @pi0 and @breakingrobot,

When updating this documentation, I noticed that here the line const _options = Object.assign({}, this.options.cookie.options, options) seems to merge the entire module options over the module cookie options? Is that intended? Is there a use case for this? Seems like it could case some unintended consequences, not matter how well it's documented.

@pi0
Copy link
Member

pi0 commented Apr 11, 2018

seems to merge the entire module options over the module cookie options

It only merges cookie related options with an optional 3rd param which is useful for example overriding default expire or cookie's domain.

BTW Thanks for nice enhancements to the docs.

@pi0 pi0 merged commit 0edebfa into nuxt-community:dev Apr 11, 2018
@benmccallum benmccallum deleted the patch-5 branch April 11, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants