Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): support querystring only url for isRelativeURL #492

Merged
merged 1 commit into from Dec 26, 2019

Conversation

yangineer
Copy link
Contributor

@yangineer yangineer commented Dec 3, 2019

Currently, the isRelativeURL regex returns false for urls with only querystring or hash part.

  • /?query=foo
  • /#bar.

This prevents redirection to those urls in the auth callback.

This PR fixes the issue.

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #492 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #492   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         2      2           
===================================
  Hits          2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21de05...f912c85. Read the comment docs.

@Swierkowski
Copy link

Swierkowski commented Dec 23, 2019

Could this be released in minor release shortly? It seems to be really simple fix.

Atinux
Atinux approved these changes Dec 26, 2019
pi0
pi0 approved these changes Dec 26, 2019
@pi0 pi0 changed the title Fix isRelativeURL to support querystring-only url fix(core): support querystring only url for isRelativeURL Dec 26, 2019
@pi0 pi0 merged commit 09d81ea into nuxt-community:dev Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants