Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix setUserToken issues #528

Merged
merged 1 commit into from Mar 2, 2020
Merged

fix: fix setUserToken issues #528

merged 1 commit into from Mar 2, 2020

Conversation

T0TProduction
Copy link
Contributor

@T0TProduction T0TProduction commented Feb 13, 2020

this PR was created to fix issues that were found with the original merge from PR 278

  • remove the logging out as we will overwrite the token anyways and it introduced unexpected and unwanted behaviour
  • remove check if we need to use token. this functions purpose is to set the token, so we will always do it

- remove the logging out as we will overwrite the token anyways and it introduced unexpected and unwanted behaviour
- remove check if we need to use token. this functions purpose is to set the token, so we will always do it
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #528 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #528   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         2      2           
===================================
  Hits          2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8546634...5d726b6. Read the comment docs.

@pi0 pi0 changed the title fix issues the original PR 278 has fix: fix setUserToken issues Mar 2, 2020
@pi0 pi0 merged commit 02d14ac into nuxt-community:dev Mar 2, 2020
3 checks passed
@pi0
Copy link
Member

pi0 commented Mar 15, 2020

Released with v4.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants