Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't accept br encoding on Server side #170

Closed
manniL opened this issue Oct 24, 2018 · 2 comments
Closed

Don't accept br encoding on Server side #170

manniL opened this issue Oct 24, 2018 · 2 comments
Labels
cmty:feature-request

Comments

@manniL
Copy link
Member

manniL commented Oct 24, 2018 •
edited

What problem does this feature solve?

Node can't parse brotli natively. Browser can.

That's why axios on server-side will throw up with gibberish characters when it retrieves content from a brotli API.

We should set the appropriate headers to avoid that behavior by default.

This feature request is available on Nuxt community (#c180)
@jericopulvera
Copy link
Contributor

@manniL did you solved this?

jericopulvera added a commit to jericopulvera/axios-module that referenced this issue Nov 5, 2018
@jericopulvera
This pr fixes brotli gibberish response on server.
99a70d3 
nuxt-community#170
@jericopulvera jericopulvera mentioned this issue Nov 5, 2018
Merged
@manniL
Copy link
Member Author

manniL commented Nov 5, 2018

@jericopulvera Check the CSB ;)

@manniL manniL assigned pi0 and unassigned pi0 Nov 5, 2018
@pi0 pi0 closed this as completed in #176 Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmty:feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@manniL @pi0 @jericopulvera