vague error message when required key is missing #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the config doesn't include one of the required keys, you get an error message as follows: `ERROR Missing or incomplete config for current environment 'development'` This update improves the error message to include the missing key in the error so the user can address it easily without having to go look into this source code. The new error message is as following (when databaseURL is not included in the config): `ERROR Missing or incomplete config for current environment 'development': key 'databaseURL' is required! `
|
Thanks a lot, works as expected. Appreciate the PR! |
|
Released with v7.2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the config doesn't include one of the required keys, you get an error message as follows:
ERROR Missing or incomplete config for current environment 'development'This update improves the error message to include the missing key in the error so the user can address it easily without having to go look into this source code.
The new error message is as following (when databaseURL is not included in the config):
ERROR Missing or incomplete config for current environment 'development': key 'databaseURL' is required!