Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): prevent build failure for ios splash image when no icon is used #362

Merged
merged 3 commits into from
Oct 6, 2020

Conversation

maybebot
Copy link
Contributor

@maybebot maybebot commented Oct 5, 2020

When the icon is set to false in config, or when the icon is not found correctly, pwa._iosSplash is undefined.
This prevents access to its proprieties and thus the nuxt build failure.

I added also a console.warn that might help in debugging future issues, to try to make it obvious that no icons are actually being generated since the path to the base icon is wrong.

Fixes #355 and #334

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #362 into master will decrease coverage by 0.23%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
- Coverage   85.40%   85.17%   -0.24%     
==========================================
  Files          10       10              
  Lines         370      371       +1     
  Branches      111      111              
==========================================
  Hits          316      316              
- Misses         50       51       +1     
  Partials        4        4              
Impacted Files Coverage Δ
lib/icon/module.js 92.30% <0.00%> (-1.03%) ⬇️
lib/meta/module.js 81.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3031e3e...316afc7. Read the comment docs.

@pi0 pi0 changed the title fix(meta) prevent build failure for ios splash image when no icon is used fix(meta )" prevent build failure for ios splash image when no icon is used Oct 6, 2020
@pi0 pi0 changed the title fix(meta )" prevent build failure for ios splash image when no icon is used fix(meta): prevent build failure for ios splash image when no icon is used Oct 6, 2020
@pi0 pi0 merged commit 494eed5 into nuxt-community:master Oct 6, 2020
@pi0
Copy link
Member

pi0 commented Oct 6, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'iphonese' of undefined
2 participants