Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workbox): offline analytics #55

Closed
wants to merge 7 commits into from

Conversation

manniL
Copy link
Member

@manniL manniL commented Mar 23, 2018

Related: #54

Depends on: #60

@pi0
Copy link
Member

pi0 commented Apr 2, 2018

Thanks, @manniL.

I think @MatteoGabriele has a better vision about this than me. As he is the creator of vue-analytics :)

@MatteoGabriele
Copy link

Hi @manniL
it definitely sounds like a nice feature for a PWA, what is your problem? :)

@manniL
Copy link
Member Author

manniL commented Apr 3, 2018

Hey @MatteoGabriele!

Thank you ☺️

I was unsure about a few things, including how to handle lodash templates properly (but that's more a Nuxt thing) and how to test the behavior correctly. But I think I solved most of the problems I had by now 😃

@pi0
Copy link
Member

pi0 commented Apr 4, 2018

@manniL So please tell me when it was ready to merge.

@manniL
Copy link
Member Author

manniL commented Apr 4, 2018

@pi0 Will do 👌

@manniL
Copy link
Member Author

manniL commented Apr 4, 2018

@pi0 As far as I figured it out, this feature can't be realized without updating workbox-build/workbox-sw to version three.

Related: #60

@pi0 pi0 changed the base branch from master to develop August 24, 2018 10:05
@pi0 pi0 changed the title [WIP] Let users enable offline GA tracking [wip] feat(workbox): offline analytics Aug 24, 2018
@pi0 pi0 changed the title [wip] feat(workbox): offline analytics feat(workbox): offline analytics Aug 24, 2018
@pi0 pi0 added the WIP Work In Progress label Aug 24, 2018
@galvez
Copy link
Contributor

galvez commented Aug 28, 2018

@manniL @pi0 GoogleChrome/workbox@f2e3165 :)

@manniL
Copy link
Member Author

manniL commented Aug 31, 2018

Awesome! thanks for the hint @galvez

@pi0 pi0 changed the base branch from develop to dev September 21, 2018 12:11
@pi0
Copy link
Member

pi0 commented Feb 4, 2019

Closing as PR is outdated :(

@pi0 pi0 closed this Feb 4, 2019
@pi0 pi0 mentioned this pull request Feb 4, 2019
@pi0 pi0 reopened this Feb 7, 2019
@pi0 pi0 closed this Feb 7, 2019
pi0 pushed a commit that referenced this pull request Feb 7, 2019
Co-Authord-By: Alexander Lichter <hello@lichter.io>
pi0 pushed a commit that referenced this pull request Feb 7, 2019
Co-authord-by: Alexander Lichter <manniL@gmx.net>
pi0 pushed a commit that referenced this pull request Feb 7, 2019
Co-authored-by: Alexander Lichter <manniL@gmx.net>
@manniL manniL deleted the feature-offline-ga branch February 8, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants