New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify Deployment fails with jimp Version 0.3.5 #84

Closed
joberthel opened this Issue Aug 24, 2018 · 11 comments

Comments

Projects
None yet
6 participants
@joberthel

joberthel commented Aug 24, 2018

"jimp": "^0.3.5"

It fails with the error: "Cannot find module 'jpgjs'"
I guess this will happen on every AWS environment.

If i add the following to my package.json, everything works fine:
"jimp": "0.3.4"

Related: oliver-moran/jimp#560

This question is available on Nuxt community (#c61)

@cmty cmty bot closed this Aug 24, 2018

@cmty cmty bot added the cmty:question label Aug 24, 2018

@cmty

This comment has been minimized.

cmty bot commented Aug 24, 2018

This issue as been imported as question since it does not respect pwa-module issue template. Only bug reports and feature requests stays open to reduce maintainers workload.
If your issue is not a question, please mention the repo admin or moderator to change its type and it will be re-opened automatically.
Your question is available at https://cmty.app/nuxt/pwa-module/issues/c61.

@pi0 pi0 reopened this Aug 24, 2018

@pi0 pi0 added cmty:bug-report and removed cmty:question labels Aug 24, 2018

@pi0

This comment has been minimized.

Member

pi0 commented Aug 25, 2018

Thanks for this bug report. While waiting for @hipstersmoothie's new release i''ll fallback jimp version

pi0 added a commit that referenced this issue Aug 25, 2018

@hipstersmoothie

This comment has been minimized.

hipstersmoothie commented Aug 26, 2018

You can make a custom build of jimp using

https://github.com/oliver-moran/jimp/tree/master/packages/custom

and exclude the TIFF package. Or you can wait until the new version of UTIF is released.

photopea/UTIF.js#43

@chrysanthos

This comment has been minimized.

chrysanthos commented Aug 27, 2018

FWIW, I am having the same error on Heroku.

@husayt

This comment has been minimized.

husayt commented Aug 30, 2018

i have the same problem with 2.4.0

@hipstersmoothie

This comment has been minimized.

hipstersmoothie commented Aug 30, 2018

I encourage anyone who wants this fixed to go bug the maintainers of UTIF on this issue photopea/UTIF.js#43 @husayt @chrysanthos

@simllll

This comment has been minimized.

Contributor

simllll commented Aug 30, 2018

I experienced this issue now even with the latest release? Seems we need to get UTIF released quickly to get this covered.

I've added "jpgjs": "github:makr28/jpgjs" to my package.json dependencies. Should do the trick in the meantime.

@hipstersmoothie

This comment has been minimized.

hipstersmoothie commented Aug 30, 2018

No release has covered this yet on jimp's end. You could always make a custom build of jimp that doesn't use the tiff type https://github.com/oliver-moran/jimp/tree/master/packages/custom

@husayt

This comment has been minimized.

husayt commented Aug 30, 2018

@hipstersmoothie

This comment has been minimized.

hipstersmoothie commented Aug 30, 2018

I totally agree. Regardless though it's breaking your build. To sidestep this right now you could just configure a custom Jimp and get all your builds passing. But it's only a band-aid if you really need TIFF support.

@pi0

This comment has been minimized.

Member

pi0 commented Sep 21, 2018

Fixed with >= 0.4.0: oliver-moran/jimp#560 (comment)

@pi0 pi0 closed this Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment