-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icon): support for iOS splash screens #308
Conversation
I was just looking for this! @dvarnai Awesome that you made a pull request. Hopefully it will be merged soon. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dvarnai! I loved your PR! But I thought I could make it a bit more maintainable. Would love to know what you think about it!
@RubenVanEldik cheers! great idea! |
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
+ Coverage 84.37% 85.51% +1.13%
==========================================
Files 10 10
Lines 320 352 +32
Branches 103 107 +4
==========================================
+ Hits 270 301 +31
- Misses 46 47 +1
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @dvarnai
@dvarnai I've made some refactors. Would be also nice if later on you could help on adding some docs. |
[1668, 2224, 'ipadpro10'], // Ipad Pro 10.5" | ||
[2048, 2732, 'ipadpro12'], // Ipad Pro 12.9" | ||
[640, 1136, 'iphonese'], // Iphone SE | ||
[50, 1334, 'iphone6'], // Iphone 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the iphone 6 splash screen suppose to be 50 px wide? Might need to be 750
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely is 750 x 1334
Hi,
This pull request adds support to automatically generate splash screens for IOS devices (#101 ) as the current implementation doesn't work as it's ignored by IOS.
The changes might not be structured in the nicest way so feel free to let me know what you think and I'll refactor it.
Best regards,
Daniel