fix: fix module options #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With no top level 'sentry' object defined in nuxt-config.js, the code would try to access property of undefined object as this.options.sentry is undefined. Fixed by using deepmerge package which both fixes the problem and makes code cleaner. Also fixed problem with merging dsn property value with the object. As dsn value is a string, don't use ... on it as that would turn string into an array of letters.
Closed
Sentry options object is called "config", not "options"
aldarund
approved these changes
Apr 2, 2019
pi0
approved these changes
Apr 2, 2019
|
Thanks @rchl for this fix and sorry for long delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With no top level 'sentry' object defined in nuxt-config.js, the code
would try to access property of undefined object as
this.options.sentry is undefined. Fixed by using deepmerge package which
both fixes the problem and makes code cleaner.
Also fixed problem with merging dsn property value with the object.
As dsn value is a string, don't use ... on it as that would turn string
into an array of letters.