Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disableTransition option and set default to true #192

Merged
merged 10 commits into from Mar 21, 2024

Conversation

zcf0508
Copy link
Contributor

@zcf0508 zcf0508 commented May 10, 2023

@netlify
Copy link

netlify bot commented May 10, 2023

Deploy Preview for nuxt-color-mode ready!

Name Link
🔨 Latest commit 8e8f171
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-color-mode/deploys/65fbfe08766a8b00084ba159
😎 Deploy Preview https://deploy-preview-192--nuxt-color-mode.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/script.ts Outdated Show resolved Hide resolved
@antfu antfu changed the title feat: add disableTransition feat: add disableTransition option and set default to true Jun 21, 2023
@antfu
Copy link
Member

antfu commented Jun 21, 2023

I am a bit hesitate if this should be enabled by default. Would love to have some feedback from the community.

@antfu
Copy link
Member

antfu commented Aug 13, 2023

I think it might be better to have it default to false for now, so we can move forward. Later we could revise the defaults on the next major

@zcf0508
Copy link
Contributor Author

zcf0508 commented Aug 14, 2023

I think it might be better to have it default to false for now, so we can move forward. Later we could revise the defaults on the next major

OK, I think it is better too.

@hacknug
Copy link

hacknug commented Sep 1, 2023

Perhaps default could come from @media/prefers-reduced-motion and then config allows you to force enable/disable.

In case it counts, I'd prefer transitions to be disabled by default.

@fos7er
Copy link

fos7er commented Oct 1, 2023

I'm looking forward for this feature

src/script.ts Outdated Show resolved Hide resolved
@danielroe danielroe merged commit 23ef3d9 into nuxt-modules:main Mar 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants