-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add github action for creating releases #1396
Conversation
Actually maybe I've jumped to conclusions to fast. |
I haven't committed according to the conventional commit 😅 , but I believe I will need to move to that commit convention in near the future when we will release the alpha version 😃
Yeah, I hope it The advantage of versioning releases with a commit hash is that you can roll back to a version that works correctly. The disadvantage is that all edge versions are recorded in npm DB for each commit, which means that versions other than the edge version will be buried because they are all listed in the version on the npm site. |
And for Nuxt the downsides are not that big because they use a separate package name for nightly releases. I guess we could do the same? It's still possible to alias that to an original name with some trickery in package.json. |
I think so too :) If you would be possible to setup for edge releasing, I would like to do as a favor 🙏 |
So what's the conclusion? Create |
I think it should be named, but I think it might be named by I’m not sure that |
I think for today until we work all together with Pooya on an official module, |
Thanks! |
@rchl |
Sorry, was sick lately. We need to do the rename first (#1402) and then adapt the script from nuxt framework I guess |
Yes. Please release, we are happy to test and provide feedback! |
It was released. See https://www.npmjs.com/package/@nuxtjs/i18n-edge You can install it locally by adding |
Awesome! Will definitely try it out. Thanks! |
@dveldhoen have you been able to get this working at all? @rchl is there anyway to know what aspects of the module should* be working with nuxt3 in relation to the docs? (ie if i follow the nuxt2 docs, how confused will i be lol :) ) |
I believe this is more or less up-to-date list https://github.com/nuxt-community/i18n-module/blob/next/TODO.md |
New to nuxt, do you have a basic config for nuxt.config.ts? No need to setup a config? Is this documentation still accurate for this module? |
@kazupon I'm setting up an action for releasing to make the process easy and transparent. I'm not sure this will work due to it being a monorepo but it should work eventually, even if it will require some tweaking.
One thing of note is that this requires a proper use of conventional commit convention for the changelog and versions to be correct so this would need to be followed like it already is on the
main
branch.Of course we can still allow non-convential commits, especially at this stage of development but then those won't be included in the changelog.