feat: disable caching for dynamic locale messages #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobbieGoede
force-pushed
the
feat/disable-cache-dynamic-locale-loader
branch
from
cafdf55
to
dd17b1e
Compare
kazupon
reviewed
Aug 31, 2023
There was a problem hiding this comment.
Good job!
Thanks!
Your PR is a great for improving next step of lazy-loading caching.
we want to disable caching by default for js and ts files, this PR is a step into that direction but does not offer control over caching yet.
I hope that you will put the docs about it.
https://v8.i18n.nuxtjs.org/guide/lazy-load-translations
Near the future it may not be necessary with cache property, but we need to understand for caching of js / ts resources.
✅ Live Preview ready!
|
BobbieGoede
force-pushed
the
feat/disable-cache-dynamic-locale-loader
branch
from
ef61a66
to
ba93582
Compare
|
I have added a warning about the caching behaviour! Will add a section about cache when adding support for the |
kazupon
approved these changes
Aug 31, 2023
DarthGigi
pushed a commit
to DarthGigi/i18n
that referenced
this pull request
Apr 16, 2024
* feat: disable caching for dynamic locale messages * docs: add warning about current cache behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#2185
❓ Type of change
📚 Description
This changes the messages caching behaviour, only message file keys are used to store and retrieve cached messages. If a message loader is dynamic (ie. a function) then its key and messages are not used for caching.
As described in #2185 (comment) we want to disable caching by default for
jsandtsfiles, this PR is a step into that direction but does not offer control over caching yet.It may be preferred to delay this until I have made a solution that provides control over the caching via a
cacheproperty.📝 Checklist