feat: locale message file cache configuration #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
reviewed
Sep 2, 2023
BobbieGoede
force-pushed
the
feat/locale-message-file-cache-configuration
branch
from
21c0a80
to
32c5691
Compare
✅ Live Preview ready!
|
BobbieGoede
force-pushed
the
feat/locale-message-file-cache-configuration
branch
from
a3b30a0
to
7999daa
Compare
kazupon
approved these changes
Sep 4, 2023
DarthGigi
pushed a commit
to DarthGigi/i18n
that referenced
this pull request
Apr 16, 2024
* feat: locale message file cache configuration * test: fix types and failing errors * fix: nuxtInternalOptions `__normalizedLocales` * refactor: simplify types * refactor: remove duplicate utility function * docs: add caching section to lazy-load translations guide * test: add test to assert cache configuration is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#2185
#2293
❓ Type of change
📚 Description
Resolves #2293
Changes locale message file configuration,
fileandfileson locales can now be set to{ path: string; cache?: boolean }, if cache is left unset caching be enabled by default for locale files that are notdynamic.It was a bit difficult to think of a proper way to test whether cache configuration is taking effect as it happens internally, the added test checks this based on debug logs, perhaps there is a better way to do this.
📝 Checklist