Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(plugin): better formatting #246

Closed
wants to merge 1 commit into from
Closed

style(plugin): better formatting #246

wants to merge 1 commit into from

Conversation

mrazauskas
Copy link

Improved formatting for plugin template. Improves readily of the rendered plugin file (see bellow). Follows ESLint rules of the repository.

Before:

const SPRITES = {
"dreams": () => import('../../assets/sprite/gen/dreams.svg'),"empty-defs": () => import('../../assets/sprite/gen/empty-defs.svg'),"love": () => import('../../assets/sprite/gen/love.svg'),"icons": () => import('../../assets/sprite/gen/icons.svg')
}

export default function(context, inject) {
    inject('svgSprite', svgSprite({
        importSprite: key => SPRITES[key] ? SPRITES[key]() : Promise.resolve(""),
        defaultSprite: 'icons',
        spriteClassPrefix: 'sprite-',
        spriteClass: 'icon',
    }))
}

After:

const SPRITES = {
  'dreams': () => import('../../assets/sprite/gen/dreams.svg'),
  'empty-defs': () => import('../../assets/sprite/gen/empty-defs.svg'),
  'love': () => import('../../assets/sprite/gen/love.svg'),
  'icons': () => import('../../assets/sprite/gen/icons.svg')
}

export default function (_, inject) {
  inject('svgSprite', svgSprite({
    importSprite: key => SPRITES[key] ? SPRITES[key]() : Promise.resolve(''),
    defaultSprite: 'icons',
    spriteClassPrefix: 'sprite-',
    spriteClass: 'icon'
  }))
}

@mrazauskas mrazauskas closed this Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant