Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parallelise async calls and fixes #690

Merged
merged 27 commits into from
Jun 20, 2023
Merged

feat: parallelise async calls and fixes #690

merged 27 commits into from
Jun 20, 2023

Conversation

ineshbose
Copy link
Collaborator

@ineshbose ineshbose commented Jun 13, 2023

Same as #679 except it reverts using await import() due to regression uses tailwindcss/loadConfig now (that specialises in loading ESM/TS configs with the help of jiti) 🙂

Play on Stackblitz - https://stackblitz.com/github/ineshbose/nuxt-tailwindcss-module/tree/refactor0

@nuxt-studio
Copy link

nuxt-studio bot commented Jun 13, 2023

Live Preview ready!

Name Edit Preview Latest Commit
TailwindCSS Edit on Studio ↗︎ View Live Preview 3f69fac

@what-the-diff
Copy link

what-the-diff bot commented Jun 13, 2023

PR Summary

  • Added a new configuration key
    A new key was added to the package.json file for better customization.
  • Improved compatibility
    Changes were made to the compatibility section in package.json.
  • Updated documentation
    Documentation for Nuxt module authors was updated in the tailwindcss hooks.
  • Fixed theme file issues
    Playground theme file extension was changed, and imports were updated.
  • Replaced server handler
    Removed addDevServerHandler and now using Nuxt's built-in server middleware.
  • Used new resolver API
    Improved path resolution for configPaths, cssPath, and more using the new resolver API.
  • Added a hook for extending tailwindConfig
    New hook allows other modules to extend tailwindConfig before TailwindCSS processes it.
  • Fixed type errors
    Resolved type errors in moduleOptions types definition file.
  • Improved configuration path resolution
    Added resolveModulePaths to properly handle paths for all layers.
  • Enhanced template creation
    Added createTemplates function for better export and alias handling in the nuxt app.
  • Fixed HMR issue
    Resolved an issue with HMR not working properly when using custom CSS files.
  • Updated viewer.ts and vite-hmr files
    Made necessary updates for compatibility and fixed test cases.
  • Fixed Windows path issues
    Resolved path issues causing test failures on Windows machines.

@atinux atinux self-requested a review June 20, 2023 08:59
@atinux atinux changed the title perf: parallelise async calls feat: parallelise async calls and fixes Jun 20, 2023
@atinux atinux merged commit d471e95 into nuxt-modules:main Jun 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't resolve #build/tailwind.config/* content property required in config
2 participants