-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: allow notification of upstream changes #1013
Conversation
472f78d
to
9a3fa44
Compare
@danielroe |
id: set-result | ||
with: | ||
script: | | ||
const { data } = await github.request('GET /repos/{owner}/{repo}/commits/{commit_sha}/pulls', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think we could instead pass the pull sha via repository_dispatch action rather than performing another request? (I wonder if two PRs merged quickly might end up creating the same issue.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's possible by changing the trigger from push
to pull_request
.
I'll give it a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By using pull_request
as the trigger, I was able to obtain the html_url
, so I tried passing it directly. What do you think?
https://github.com/wattanx/repository-dispatch-owner/blob/main/.github/workflows/dispatch-update-file.yml#L22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect!
π Linked issue
β Type of change
π Description
The composables in nuxt/bridge are ported from nuxt 3.
So, if there are changes in nuxt 3, we need to follow the changes.
This PR notifies this repository of any modifications on the nuxt 3 side to reduce porting leaks.
Examples of Notification:
wattanx/repository-dispatch-target#4
The notifier prepares the following workflow:
https://github.com/wattanx/repository-dispatch-owner/blob/main/.github/workflows/dispatch-update-file.yml
π Checklist