Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: allow notification of upstream changes #1013

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Dec 10, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)

πŸ“š Description

The composables in nuxt/bridge are ported from nuxt 3.
So, if there are changes in nuxt 3, we need to follow the changes.
This PR notifies this repository of any modifications on the nuxt 3 side to reduce porting leaks.

Examples of Notification:
wattanx/repository-dispatch-target#4

The notifier prepares the following workflow:
https://github.com/wattanx/repository-dispatch-owner/blob/main/.github/workflows/dispatch-update-file.yml

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx marked this pull request as ready for review December 10, 2023 12:47
@wattanx
Copy link
Collaborator Author

wattanx commented Dec 10, 2023

@danielroe
The minimum required information can be output!
Could you review whether the approach seems fine and if there's any additional information needed?

id: set-result
with:
script: |
const { data } = await github.request('GET /repos/{owner}/{repo}/commits/{commit_sha}/pulls', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think we could instead pass the pull sha via repository_dispatch action rather than performing another request? (I wonder if two PRs merged quickly might end up creating the same issue.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's possible by changing the trigger from push to pull_request.
I'll give it a try.

Copy link
Collaborator Author

@wattanx wattanx Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using pull_request as the trigger, I was able to obtain the html_url, so I tried passing it directly. What do you think?
https://github.com/wattanx/repository-dispatch-owner/blob/main/.github/workflows/dispatch-update-file.yml#L22

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@danielroe danielroe merged commit 4a397f9 into main Dec 13, 2023
9 checks passed
@danielroe danielroe deleted the ci/needs-port-upstream branch December 13, 2023 17:41
@github-actions github-actions bot mentioned this pull request Dec 13, 2023
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants