Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: notify nuxt/bridge when composables change #24752

Merged
merged 2 commits into from Dec 15, 2023

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Dec 14, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The composables in nuxt/bridge are ported from nuxt 3.
So, if there are changes in nuxt 3, we need to follow the changes.
In the workflow being added this time, if composables are modified in Nuxt 3, a notification will be sent to nuxt/bridge.

nuxt/bridge is already set up to receive notifications.
nuxt/bridge#1013

(I would like to discuss if this name for the workflow is appropriate.)

Todo

  • Secrets must be prepared.
    • Need to add contents: read & write for nuxt bridge repo.
    • metadata: read only (automatically selected when selecting the contents permission)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Dec 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Dec 14, 2023
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks πŸ‘Œ

@wattanx
Copy link
Collaborator Author

wattanx commented Dec 15, 2023

@danielroe
Could you create a Personal Access Token (PAT) to be used in Actions?
(It is needed to add permissions to nuxt/bridge.)

  • In the case of a fine-grained personal access token:
    • need contents: read & write and metadata: read only permissions.
  • In the case of a classic PAT:
    • need repo scope

https://github.com/peter-evans/repository-dispatch?tab=readme-ov-file#token

(In the code, it is set to ACCESS_TOKEN.)

Co-authored-by: Daniel Roe <daniel@roe.dev>
@wattanx wattanx marked this pull request as ready for review December 15, 2023 12:43
@danielroe danielroe changed the title ci: notify nuxt/bridge of composables changes ci: notify nuxt/bridge when composables change Dec 15, 2023
@danielroe danielroe merged commit ce18fda into nuxt:main Dec 15, 2023
6 checks passed
@wattanx wattanx deleted the ci/dispatch-nuxt-bridge branch December 15, 2023 12:44
@github-actions github-actions bot mentioned this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants