Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mock new hookable methods #921

Merged
merged 2 commits into from Oct 2, 2023
Merged

fix: mock new hookable methods #921

merged 2 commits into from Oct 2, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This mocks three missing hook methods added in newer hookable.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Oct 2, 2023
@danielroe danielroe requested review from pi0 and wattanx October 2, 2023 11:39
@danielroe danielroe self-assigned this Oct 2, 2023
@danielroe danielroe mentioned this pull request Oct 2, 2023
Closed
pi0
pi0 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

(Also why we would benefit by refactoring more code to directly depend on nuxt.hooks to make sure similar forward compatibility is guaranteed in nuxt 3..)

@danielroe danielroe mentioned this pull request Oct 2, 2023
Merged
8 tasks
danielroe
danielroe commented Oct 2, 2023
View reviewed changes
packages/bridge/module.cjs Outdated Show resolved Hide resolved
@danielroe danielroe changed the title fix: mock hook methods for nuxi fix: mock new hookable methods Oct 2, 2023
@danielroe danielroe merged commit 84a8419 into main Oct 2, 2023
9 checks passed
@danielroe danielroe deleted the feat/mock-hook-methods branch October 2, 2023 12:06
@wattanx
Copy link
Collaborator

wattanx commented Oct 2, 2023

Thank you ❤️

@danielroe danielroe mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@wattanx wattanx Awaiting requested review from wattanx

Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielroe @wattanx @pi0