Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): mock hookable methods on nuxt 2 #23502

Merged
merged 4 commits into from Oct 2, 2023
Merged

fix(nuxt): mock hookable methods on nuxt 2 #23502

merged 4 commits into from Oct 2, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Oct 2, 2023 •
edited

🔗 Linked issue

related nuxt/bridge#921
closes nuxt/cli#230

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This polyfills some hook methods relied on by nuxi/bridge so they are available from the moment nuxt is loaded, rather than after ready() is called.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 October 2, 2023 11:54
@danielroe danielroe self-assigned this Oct 2, 2023
@stackblitz
Copy link

stackblitz bot commented Oct 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

pi0
pi0 reviewed Oct 2, 2023
View reviewed changes
packages/kit/src/loader/nuxt.ts Outdated Show resolved Hide resolved
@danielroe danielroe changed the title fix(nuxt): mock hookable methods on old nuxt fix(nuxt): mock hookable methods on nuxt 2 Oct 2, 2023
@danielroe danielroe merged commit 1e3d989 into main Oct 2, 2023
35 checks passed
@danielroe danielroe deleted the fix/hookable-nuxt2 branch October 2, 2023 12:42
@github-actions github-actions bot mentioned this pull request Oct 2, 2023
Merged
@chz chz mentioned this pull request Oct 3, 2023
Closed
@wattanx wattanx mentioned this pull request Oct 5, 2023
Closed
@danielroe danielroe mentioned this pull request Oct 18, 2023
Closed
manniL pushed a commit that referenced this pull request Dec 11, 2023
@danielroe @manniL
fix(nuxt): mock hookable methods on nuxt 2 (#23502)
7b17f92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
2.x bug kit 🔨 p3-minor-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @pi0