Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typecheck): use bunx if is running on bun #494

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HigherOrderLogic
Copy link

πŸ”— Linked issue

Fix #461.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

If user is running on Bun, use bunx to install deps globally and run vue-tsc to type check.

@pi0
Copy link
Member

pi0 commented Oct 4, 2024

Linking to unjs/nypm#145

@HigherOrderLogic
Copy link
Author

Also, could we have a new citty release? There's quite a number of unreleased new features in the repo right now.

@pi0
Copy link
Member

pi0 commented Oct 5, 2024

There's quite a number of unreleased new features in the repo right now.

Some are actually the reason new release is being blocked. I am sorry. please mention if there is any "bug" that needs hotfix and i can help on that. in a issue in citty repository. πŸ™πŸΌ

@HigherOrderLogic
Copy link
Author

please mention if there is any "bug"

Thanks, already did in unjs/citty#166.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type-checking with Bun
2 participants