Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decodeURI before searching query #55

Merged
merged 1 commit into from
May 29, 2020

Conversation

hunterliu1003
Copy link
Contributor

@hunterliu1003 hunterliu1003 commented May 27, 2020

This should fix #54 by decodeURI request url before searching query

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          13       13           
  Lines         410      410           
  Branches       76       76           
=======================================
  Hits          383      383           
  Misses         24       24           
  Partials        3        3           
Impacted Files Coverage Δ
lib/middleware.js 94.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7146233...b7740e8. Read the comment docs.

@hunterliu1003
Copy link
Contributor Author

This is my first time contributing an open source project

if there is anything that can be improved, please let me know

@atinux atinux requested a review from benjamincanac May 27, 2020 16:05
@benjamincanac benjamincanac merged commit 66781a8 into nuxt:master May 29, 2020
pi0 pushed a commit that referenced this pull request Feb 8, 2022
Co-authored-by: Renovate Bot <bot@renovateapp.com>
pi0 pushed a commit that referenced this pull request May 5, 2022
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request url should decodeURI(url) before searching query in lib/middleware.js
3 participants