Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: live editing #125

Merged
merged 7 commits into from
Jun 16, 2020
Merged

feat: live editing #125

merged 7 commits into from
Jun 16, 2020

Conversation

benjamincanac
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #125 into master will decrease coverage by 1.68%.
The diff coverage is 62.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   93.33%   91.64%   -1.69%     
==========================================
  Files          14       14              
  Lines         465      479      +14     
  Branches       91       97       +6     
==========================================
+ Hits          434      439       +5     
- Misses         28       35       +7     
- Partials        3        5       +2     
Impacted Files Coverage Δ
lib/index.js 91.04% <50.00%> (-1.27%) ⬇️
lib/middleware.js 81.96% <56.52%> (-12.58%) ⬇️
lib/database.js 82.17% <100.00%> (ø)
lib/query-builder.js 100.00% <100.00%> (ø)
lib/parsers/markdown/compilers/json.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c267fb0...79aa9d0. Read the comment docs.

lib/middleware.js Outdated Show resolved Hide resolved
lib/middleware.js Outdated Show resolved Hide resolved
Copy link
Member

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, could you add a note on the documentation for Live editing into the Writing section?

@benjamincanac benjamincanac merged commit 2570fd0 into master Jun 16, 2020
@atinux atinux deleted the feat/live-editing branch June 17, 2020 11:08
pi0 pushed a commit that referenced this pull request May 5, 2022
Co-authored-by: Ahad Birang <farnabaz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants