Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(document-driven): throw 404 error when content is missing #1394

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

farnabaz
Copy link
Member

πŸ”— Linked issue

resolves nuxt-themes/docus#587

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 29, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit 5d90c38
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62e7af3259d0070008f5530e
😎 Deploy Preview https://deploy-preview-1394--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@farnabaz farnabaz marked this pull request as ready for review July 29, 2022 11:38
@atinux
Copy link
Member

atinux commented Jul 29, 2022

Could we check if it sends back the 404 code on SSR as well?

Any chance to add a test case for it?

@farnabaz farnabaz merged commit 343db3e into main Aug 2, 2022
@farnabaz farnabaz deleted the fix/404-page branch August 2, 2022 13:57
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 page is buggy
3 participants