Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add classes for live editing #258

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

alvarosabu
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Adds author to nuxt-content-container when is being edited.
  • Adds nuxt-content-editor class to text area to avoid using !important if you want to re-style the live edit input.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

I think it doesn't need to be pointed out in the documentation, but If you think it does, I'm happy to add it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2020

Codecov Report

❗ No coverage uploaded for pull request base (dev@cf5afe1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #258   +/-   ##
======================================
  Coverage       ?   89.46%           
======================================
  Files          ?       15           
  Lines          ?      541           
  Branches       ?      111           
======================================
  Hits           ?      484           
  Misses         ?       50           
  Partials       ?        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5afe1...17c348c. Read the comment docs.

@alvarosabu alvarosabu changed the title Add classes for live editing feat: add classes for live editing Jul 13, 2020
@Atinux
Copy link
Member

Atinux commented Jul 15, 2020

Thank you for the PR, I would actually rename author to is-editing instead

@alvarosabu
Copy link
Contributor Author

Sure thing.

@benjamincanac benjamincanac merged commit 6f6cf12 into nuxt:dev Jul 17, 2020
@benjamincanac
Copy link
Member

Thanks @alvarosaburido!

@alvarosabu alvarosabu deleted the live-edit-styling branch July 19, 2020 14:03
benjamincanac pushed a commit that referenced this pull request Jul 20, 2020
* Add classes for live editing

* feat(lib): add line between selectors

* feat(lib): change author to is-editing
benjamincanac pushed a commit that referenced this pull request Jul 27, 2020
* Add classes for live editing

* feat(lib): add line between selectors

* feat(lib): change author to is-editing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants