Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use core-js@3 by default #594

Merged
merged 3 commits into from
Sep 1, 2020
Merged

feat: use core-js@3 by default #594

merged 3 commits into from
Sep 1, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 27, 2020

It is a long time since core-js@3 released but we are still using core-js@2 by default to avoid breaking changes. This is going to make more problems for nuxt@2 users as more packages updated.

Since 2.14.0 we auto detect core-js version by resolving installed version from root dir (src) so this is a non-breaking change encouraging users to use 3.x for newly created projects.

PS: PR also contains sorting of dependencies by yarn

@pi0 pi0 requested review from clarkdo and Atinux August 27, 2020 15:43
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicit corejs: 3 config in build.babel is needed.

Oh, not realized it's auto detected now.

@pi0 pi0 merged commit 146a312 into master Sep 1, 2020
@pi0 pi0 deleted the feat/corejs-3 branch September 1, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants