Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): support pug template #960

Merged
merged 7 commits into from Sep 28, 2022

Conversation

yanskun
Copy link
Sponsor Contributor

@yanskun yanskun commented Aug 6, 2022

Types of changes

  • New feature (a non-breaking change which adds functionality)

Description

create-nuxt-app is essential for creating Nuxt Project and I love it.
That's why I use this over and over again.

I prefer Pug over HTML because it's easier to read.
Also, I feel that there are many such friends. (#378)

After creating-nuxt-app, every time pug is installed and the page file is changed to <template lang="pug">.

I wanted to solve this, so I tried to fix it this time!
thank you

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@yanskun yanskun changed the title feat: add pug template Make Pug template selectable Aug 6, 2022
@yanskun yanskun marked this pull request as ready for review August 6, 2022 00:50
@yanskun
Copy link
Sponsor Contributor Author

yanskun commented Sep 22, 2022

@Atinux (I didn't know who to mention)
I love Nuxt, and love Pug just as much.

I feel this is not actively developed.
However, until Nuxt3 is officially released, it will be used.

How can I get you to review.

@Atinux Atinux requested a review from clarkdo September 22, 2022 09:50
Copy link
Member

Atinux commented Sep 22, 2022

Thank you for your help @yanskun

I added Clark as review since he has been working a lot on this project.

@clarkdo clarkdo changed the title Make Pug template selectable feat(template): support pug template Sep 22, 2022
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!


export default Vue.extend({
name: 'IndexPage'
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the end tag

@clarkdo clarkdo merged commit 49c7a80 into nuxt:master Sep 28, 2022
@yanskun yanskun deleted the feat/add-pug-template branch September 29, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants