add TypeScript integration #207

lv-kit · 2019-03-23T07:22:20Z

Hello everyone !

Added TypeScript integration option for Merge nuxt / nuxt.js # 5079. This will allow you to use TypeScript soon.

With the addition of the TypeScript selection, the choices are as follows:

In addition, the version of Nuxt.js has been updated to 2.5.1 to support TS.

kevinmarrec · 2019-03-23T15:56:15Z

Thanks @takehiro-takahashi ! I don't know if we should maybe wait before releasing this feature as we're planning to change again how is handled tsconfig.json.

/cc @pi0 WDYT ?

package.json

clarkdo · 2019-03-23T17:47:05Z

@takehiro-takahashi Thank you so much for the contribution

@takehiro-takahashi @kevinmarrec @pi0 I think if ts is selected, typescript related code should be changed, like changing index.vue to ts lang.

kevinmarrec · 2019-03-23T17:56:27Z

@clarkdo Yes you're right

lv-kit · 2019-03-23T18:07:10Z

@clarkdo @kevinmarrec

I also thought that it might be necessary.
However, considering the freedom of users, I thought that it would be sufficient for the environment to be able to use TS.
If you need the TS version of the source code, I will prepare it immediately.

lv-kit · 2019-03-24T03:37:14Z

@clarkdo @kevinmarrec

Added TS base of Vuetify and nuxt default. iview is not supported because iview's TS type definition file itself did not work.
I am glad that you confirm at the timing.

pi0 · 2019-04-08T17:35:43Z

test/snapshots/index.test.js.md

@@ -33,7 +33,7 @@ Generated by [AVA](https://ava.li).
    {
      dependencies: {
        'cross-env': '^5.2.0',
-        nuxt: '^2.4.0',
+        nuxt: '^2.5.1',


Is version bumped by this PR? And if so why not using 2.6.1?

pi0 · 2019-04-08T17:37:37Z

template/_package.json

@@ -50,7 +50,9 @@
    "nuxt-buefy": "^0.3.2"<% } else if (ui === 'iview') { %>,
    "iview": "3.1.5"<% } %><% if (axios === 'yes') { %>,
    "@nuxtjs/axios": "^5.3.6"<% } %><% if (pwa === 'yes') { %>,
-    "@nuxtjs/pwa": "^2.6.0"<% } %><% if (ui === 'tachyons') { %>,
+    "@nuxtjs/pwa": "^2.6.0"<% } %><% if (typescript === 'yes') { %>,
+    "@nuxt/typescript": "^2.5.1",


This would be better to be in devDependencies and instead, adding ts-node and typescript to dependencies.

pi0 · 2019-04-08T18:41:06Z

template/_package.json

    "vuetify-loader": "^1.2.1"<% } else if (ui === 'bulma') { %>,
    "@nuxtjs/bulma": "^1.2.1"<% } else if (ui === 'element-ui') { %>,
    "element-ui": "^2.4.11"<% } else if (ui === 'ant-design-vue') { %>,
    "ant-design-vue": "^1.1.10"<% } else if (ui === 'buefy') { %>,
    "nuxt-buefy": "^0.3.2"<% } else if (ui === 'iview') { %>,
    "iview": "3.1.5"<% } %><% if (axios === 'yes') { %>,
    "@nuxtjs/axios": "^5.3.6"<% } %><% if (pwa === 'yes') { %>,
-    "@nuxtjs/pwa": "^2.6.0"<% } %><% if (ui === 'tachyons') { %>,
+    "@nuxtjs/pwa": "^2.6.0"<% } %><% if (typescript === 'yes') { %>,
+    "ts-node": "^8.0.3",


I think typescript is a peer dependency of it (for the compiler). /cc @kevinmarrec

That's true, and as typescript is shipped in @nuxt/typescript which is installed as devDep, it will bring the issue that typescript won't be installed in production.

kevinmarrec · 2019-04-15T19:56:10Z

@pi0 What do you think of the status of this PR ? It seems kind of ready to me, unless we change our typescript behavior again (which has highly chance to happen, regarding a potential nuxt.config .ts extension check to enable TS support)

pi0 · 2019-04-29T15:03:22Z

I would suggest holding on this PR until latest final breaking change.

robsontenorio · 2019-05-16T01:19:44Z

@takehiro-takahashi @pi0 Is it time?

- ts-node - typescript

kevinmarrec · 2019-06-02T21:20:31Z

Sorry for delay, we're waiting last breaking changes I'm wonking on (outsourcing typescript support in dedicated module & repository) to get this PR finally ready & bring this typescript integration.

florianrusch · 2019-08-09T19:01:01Z

@kevinmarrec @pi0 @takehiro-takahashi Are we still waiting? 🙂 Is there anything we can help with?

kevinmarrec · 2019-08-09T19:06:03Z

@florianrusch Well lof things have changed since the last status of this PR
Furthermore I'm not sure if we should showcase vue-property-decorator (Class API)
We should most probably showcase standard (Object) API with TypeScript.
Something we can also do could be : let user select between 3 Available Vue API (object, class, function), see https://typescript.nuxtjs.org/cookbook/components.html (SPOIL Nuxt 2.9 :D)

kevinmarrec · 2019-08-30T08:35:43Z

@takehiro-takahashi Thank you so much for your time, but I'm closing in favor of #328

support typescript

be8d45e

lv-kit changed the title ~~support typescript~~ [WIP]support typescript Mar 23, 2019

lv-kit added 3 commits March 23, 2019 16:56

fix version

e9eb0ab

fix yarn test

46a48f2

yarn lint --fix

fb1f46f

lv-kit changed the title ~~[WIP]support typescript~~ add TypeScript integration Mar 23, 2019

manniL requested review from clarkdo and kevinmarrec March 23, 2019 10:14

clarkdo reviewed Mar 23, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

fix package version

3839792

lv-kit added 4 commits March 24, 2019 12:24

add vuetify-ts

d5745a3

add nuxt-ts

1e823c2

add framework setting

8ccc847

add test result

1c99fa3

clarkdo requested a review from pi0 April 8, 2019 14:14

pi0 reviewed Apr 8, 2019

View reviewed changes

update packages

a736f14

pi0 reviewed Apr 8, 2019

View reviewed changes

add typescript at dependencies

bcbfbe8

lv-kit added 4 commits April 29, 2019 17:57

change vuetify-ts and update package

243a3ce

test result

7dd3409

change erro type

eff0fe3

fix type

42c8d53

lv-kit added 3 commits April 29, 2019 18:20

update README

4681a6c

add package name

776d73e

fix type

852696e

lv-kit added 4 commits May 21, 2019 00:04

ts errorLayout title

98d1513

Merge branch 'master' into support_typescript

c69f48d

update package

e946372

- ts-node - typescript

fix test

3d0a699

lv-kit added 6 commits June 3, 2019 14:42

fix prettier

0afbca4

fix lint error

de66786

add ts lint

9779285

remove this, fix warning

96f277d

add nuxt error page

79bf776

update test result

a9923ef

clarkdo force-pushed the master branch from 1ce9e74 to 0d66e17 Compare July 27, 2019 08:41

krsnadjava25 added a commit to krsnadjava25/nuxt-ts that referenced this pull request Aug 11, 2019

Typescript setup copying nuxt/create-nuxt-app#207

fdd2255

kevinmarrec closed this Aug 30, 2019

nh0007 mentioned this pull request Dec 19, 2019

Nuxt网站搭建 nh0007/blogs#2

Open

lv-kit deleted the support_typescript branch January 10, 2020 04:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add TypeScript integration #207

add TypeScript integration #207

lv-kit commented Mar 23, 2019 •

edited

Loading

kevinmarrec commented Mar 23, 2019

clarkdo commented Mar 23, 2019 •

edited

Loading

kevinmarrec commented Mar 23, 2019

lv-kit commented Mar 23, 2019

lv-kit commented Mar 24, 2019

pi0 Apr 8, 2019

pi0 Apr 8, 2019

pi0 Apr 8, 2019

kevinmarrec Apr 8, 2019

kevinmarrec commented Apr 15, 2019

pi0 commented Apr 29, 2019

robsontenorio commented May 16, 2019

kevinmarrec commented Jun 2, 2019 •

edited

Loading

florianrusch commented Aug 9, 2019

kevinmarrec commented Aug 9, 2019 •

edited

Loading

kevinmarrec commented Aug 30, 2019

add TypeScript integration #207

add TypeScript integration #207

Conversation

lv-kit commented Mar 23, 2019 • edited Loading

kevinmarrec commented Mar 23, 2019

clarkdo commented Mar 23, 2019 • edited Loading

kevinmarrec commented Mar 23, 2019

lv-kit commented Mar 23, 2019

lv-kit commented Mar 24, 2019

pi0 Apr 8, 2019

Choose a reason for hiding this comment

pi0 Apr 8, 2019

Choose a reason for hiding this comment

pi0 Apr 8, 2019

Choose a reason for hiding this comment

kevinmarrec Apr 8, 2019

Choose a reason for hiding this comment

kevinmarrec commented Apr 15, 2019

pi0 commented Apr 29, 2019

robsontenorio commented May 16, 2019

kevinmarrec commented Jun 2, 2019 • edited Loading

florianrusch commented Aug 9, 2019

kevinmarrec commented Aug 9, 2019 • edited Loading

kevinmarrec commented Aug 30, 2019

lv-kit commented Mar 23, 2019 •

edited

Loading

clarkdo commented Mar 23, 2019 •

edited

Loading

kevinmarrec commented Jun 2, 2019 •

edited

Loading

kevinmarrec commented Aug 9, 2019 •

edited

Loading