Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): use cac for cli #264

Merged
merged 3 commits into from
Jun 27, 2019
Merged

feat(cli): use cac for cli #264

merged 3 commits into from
Jun 27, 2019

Conversation

2nthony
Copy link
Contributor

@2nthony 2nthony commented Jun 21, 2019 •
edited 

$ yarn create nuxt-app --help
...
success Installed "create-nuxt-app@2.7.1" with binaries:
      - create-nuxt-app
> Generating Nuxt.js project in /Users/evila/--help
? Project name (--help)

The target path is /User/evila/--help obviously not right 馃

@2nthony 2nthony changed the title refactor(cli): use cac refactor(cli): use cac for cli.js Jun 21, 2019
@manniL manniL requested a review from clarkdo June 24, 2019 19:06
clarkdo
clarkdo reviewed Jun 26, 2019
View reviewed changes
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evillt Thank you for the pr, I'm curious that what's the reason for choosing cac, is there any benefit comparing with commander or minimalist ?

@2nthony
Copy link
Contributor Author

2nthony commented Jun 27, 2019

CAC is very similar to commander.

The main reason is SAO already taken CAC as a dependency(you can see here), reuse a node-module to keep create-nuxt-app the same download size.

How do you think 馃

@clarkdo clarkdo changed the title refactor(cli): use cac for cli.js feat(cli): use cac for cli Jun 27, 2019
@clarkdo clarkdo changed the title feat(cli): use cac for cli feat(cli): use cac for cli Jun 27, 2019
@clarkdo clarkdo merged commit b80fa2d into nuxt:master Jun 27, 2019
@clarkdo
Copy link
Member

clarkdo commented Jun 27, 2019

Thanks

@2nthony
Copy link
Contributor Author

2nthony commented Jun 27, 2019

It would be honer 馃拑

@2nthony 2nthony deleted the refactor-bin branch October 23, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkdo clarkdo clarkdo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@2nthony @clarkdo