Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open graph breaks when tag value is numeric #563

Closed
Aareksio opened this issue Jan 7, 2024 · 3 comments
Closed

fix: open graph breaks when tag value is numeric #563

Aareksio opened this issue Jan 7, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Aareksio
Copy link

Aareksio commented Jan 7, 2024

🐛 The bug

useSeoMeta({
  ogImageWidth: 200,
});

When item.value is numeric, item.value.match is not a function at

:href="item.value.match(/^https?:\/\//) ? item.value : undefined"

Results in broken "Tags" section:
Screenshot 2024-01-07 at 22 56 52

🛠️ To reproduce

https://stackblitz.com/edit/github-gqikj7

🌈 Expected behavior

Tab not breaking :)

Screenshot 2024-01-07 at 22 58 22

ℹ️ Additional context

No response

@Aareksio Aareksio added the bug Something isn't working label Jan 7, 2024
@manniL manniL added the good first issue Good for newcomers label Jan 7, 2024
@arashsheyda
Copy link
Member

@Aareksio I can't see the problem exactly, it's working

Screenshot 2024-01-09 at 12 31 52 PM

@Aareksio
Copy link
Author

Aareksio commented Jan 9, 2024

@arashsheyda You are right, it only happens after installing @nuxtseo/module (now moved to @nuxtjs/seo). Updated repro. I am not sure which repo this issue belongs, technically it is something about unhead, but in the end it is easy fix in nuxt-devtools.

@arashsheyda
Copy link
Member

@Aareksio I'll try to install it and test it then, thanks (and if you like to fix it PR welcome)

@antfu antfu closed this as completed in c63055a Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants