Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT sample code link is broken. #710

Closed
konojunya opened this issue Aug 16, 2018 · 3 comments
Closed

JWT sample code link is broken. #710

konojunya opened this issue Aug 16, 2018 · 3 comments

Comments

@konojunya
Copy link

konojunya commented Aug 16, 2018

Version

1.4.0

Reproduction link

https://ja.nuxtjs.org/examples/auth-external-jwt/

Steps to reproduce

I think that the download site of DownGit will be displayed when pushing the download link of this page, but the link of GitHub displayed there is broken.

What is expected ?

A neat GitHub link of Auth External API (JWT)

What is actually happening?

It becomes 404 at the link destination of GitHub.

Additional comments?

I think that it should be this link.

https://github.com/ahadyekta/nuxt-auth-external-jwt

This link can be found in examples/auth-external-jwt.md of Nuxt/docs.

I will send you a Pull Request if you like.

Thanks.

@ghost ghost added the bug-report label Aug 16, 2018
@Atinux
Copy link
Member

Atinux commented Aug 16, 2018

Sure, please send us a PR :)

@konojunya
Copy link
Author

konojunya commented Aug 16, 2018

In order to solve this issue I thought that I had to write a sample code by creating a directory named auth-jwt in the examples of nuxt/nuxt.js so I made PR to nuxt/nuxt.js.

@konojunya
Copy link
Author

merged nuxt/nuxt#3746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants