-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npx nuxi module add eslint
adds as main dependency and doesn't create config file
#422
Comments
This is working as expected, as the script will add the module where
That's a good point. Let me see how we can improve that
This happens in the module, you need to run |
Any idea why the starters have these dependencies not in dev?
👍
Do you think this is clear to other users or should we update documentation to mention this? |
I don't. But in an app I guess deps and devDeps do have much difference. If you want to discuss, I suggest you to create an issue in the template repo instead.
Totally - PR welcome if you want to help on that. Thanks |
|
@antfu Thanks for merging! Want to keep this one open for the missing |
I am not sure what it's the best way to do it. The nuxi command does not support custom command yet, so I guess it might be better to just document it and ask users to install? |
At this point, the Quick Setup may not be "quicker" because you have to run two commands. Perhaps we should remove this section and stick with the manual setup until the cli adds this feature. Thoughts? BTW, I recently binge-watched your 'learn.nuxt.com' stream series and learned a lot! Thank you very much 🙏. |
@antfu bump in case you missed my comment. |
Environment
StackBlitz: https://nuxt.new/s/v3
Package
@nuxt/eslint
Reproduction
Open https://nuxt.new/s/v3 and run
npx nuxi module add eslint
✔ See module added
❌ See dependency added as main and not as dev
❌ See missing
eslint
dependency❌ See missing
eslint.config.mjs
Describe the bug
The Quick Setup sections assumes the provided command will setup all for you, but it misses correctly adding dependacy under
devDependencies
, it missed addingeslint
, and it doesn't generateeslint.config.mjs
like it states it would.Without these things, the manual setup should be faster and therefore the recommended way to get started.
If the above is an issue with
nuxi
or a limitation, I think we should update the docs to clarify these things. I'd be willing to open a PR if this meets the projects goals.Additional context
No response
Logs
No response
The text was updated successfully, but these errors were encountered: