Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(vite): support Vite's transformIndexHtml hook #1711

Closed
wants to merge 1 commit into from

Conversation

antfu
Copy link
Member

@antfu antfu commented Nov 5, 2021

πŸ”— Linked issue

Supports Vite's transformIndexHtml hook
https://vitejs.dev/guide/api-plugin.html#transformindexhtml

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Nov 5, 2021

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: dd65101

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/618499367014300008957a0a

@pi0
Copy link
Member

pi0 commented Nov 5, 2021

I think it is best if not to support vite specific option if it is already possible with nitro. Please use an issue to describe the usecase we can probably find an alternative :)

@pi0 pi0 closed this Nov 5, 2021
@antfu antfu deleted the feat/vite-transform-index branch December 2, 2021 05:19
@webfansplz
Copy link
Contributor

Some Vite plugins that use this option will not work well with Nuxt without this support . e.g. :

https://github.com/webfansplz/vite-plugin-vue-inspector/blob/043827dbf4193aaa00fb58447f466cd8e94dd2f9/src/index.ts#L34

@pi0
Copy link
Member

pi0 commented Apr 29, 2022

I see @webfansplz but we don't even have this hook anymore to directly extend HTML template. Extending needs to happen in runtime and we probably need a nuxt module for such integration. Would be happy to help if you make an issue in vite plugin repos regarding nuxt support.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants