Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(test-utils): hardcode ipv4 ip for localhost #4998

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#13964

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Seems we have an issue with ipv6 in testing that we can avoid by hard-coding to ipv4.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from antfu May 16, 2022 10:40
@danielroe danielroe self-assigned this May 16, 2022
@netlify
Copy link

netlify bot commented May 16, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 4f805ea
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62822a2e53eac50009bb7df9

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage test-utils labels May 16, 2022
@antfu antfu merged commit cd37a21 into main May 17, 2022
@antfu antfu deleted the fix/test-localhost branch May 17, 2022 01:40
@pi0 pi0 mentioned this pull request Jun 10, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage test-utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipv4 / ipv6 - Problem when using $fetch() while testing with vitest
2 participants