Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): use externality to handle vite-node externals #6153

Merged
merged 1 commit into from Jul 26, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Jul 26, 2022

πŸ”— Linked issue

nuxt/nuxt#13994

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This reuses the externalization options from dev-bundler to make the behaviour more consistent.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 26, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 78af77e
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62dfe5accaf9f6000ade6329
😎 Deploy Preview https://deploy-preview-6153--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu antfu mentioned this pull request Jan 19, 2023
4 tasks
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be nice if later refactor isExternal utility since is almost repeated in dev-bundler

@pi0 pi0 changed the title fix(vite-node): use externality to handle externals fix(vite): use externality to handle vite-node externals Jul 26, 2022
@pi0 pi0 merged commit 5e62e0f into main Jul 26, 2022
@pi0 pi0 deleted the fix/vite-node-external branch July 26, 2022 13:49
@antfu antfu mentioned this pull request Aug 4, 2022
7 tasks
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants