Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): clear vite-node runner cache after each render #6154

Merged
merged 1 commit into from Jul 26, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Jul 26, 2022

πŸ”— Linked issue

nuxt/nuxt#13994

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Otherwise, the cache will be preseved across builds

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 26, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit ac5b81b
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62dfe6ef1b9b7f0009dd8f34
😎 Deploy Preview https://deploy-preview-6154--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu antfu mentioned this pull request Jan 19, 2023
4 tasks
@pi0
Copy link
Member

pi0 commented Jul 26, 2022

Do you have any plans to make the cache more persistent? In case of no rebuilds, i think we are just loosing cache possibility this way.

@pi0 pi0 changed the title fix(vite-node): clear cache after each render fix(nuxt): clear vite-node runner cache after each render Jul 26, 2022
@pi0 pi0 merged commit a585086 into main Jul 26, 2022
@pi0 pi0 deleted the fix/vite-node-cache branch July 26, 2022 13:13
@antfu
Copy link
Member Author

antfu commented Jul 26, 2022

Yeah I will make future improvements to only invalidate based on what files are changed. However, that requires some complexity to communicate between the process. The first step is #6156, and I will experiment with solutions in later PRs as improvements.

@antfu antfu mentioned this pull request Aug 4, 2022
7 tasks
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants