This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxi, kit): enable esmResolve flag for jiti
#6356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
changed the title
esmResolve flag for `jitiesmResolve flag for jiti
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related: #6340, unjs/unctx#23, unjs/unctx#25
❓ Type of change
📚 Description
Some dependencies like
estree-walker, are not only esm-only but only useexports.importfield inpackage.json. This makes sure they are broken unless using esm native resolution!We introduced an experimental flag few months ago for jiti to enable esm resolution and handle such package. It is already enabled for c12 and framework repo. This PR enabled it for kit utils as well.
📝 Checklist