Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps)!: update estree-walker to v3 #23

Merged
merged 3 commits into from
Aug 3, 2022
Merged

chore(deps)!: update estree-walker to v3 #23

merged 3 commits into from
Aug 3, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 3, 2022

Breaking change: unctx/plugin only works with ESM imports after this change since estree-walker is also esm-only.

@pi0
Copy link
Member Author

pi0 commented Aug 3, 2022

Vitest is failing with this error:

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in /Users/pooya/Code/unctx/node_modules/estree-walker/package.json
    at new NodeError (node:internal/errors:372:5)
    at throwExportsNotFound (node:internal/modules/esm/resolve:472:9)
    at packageExportsResolve (node:internal/modules/esm/resolve:693:7)
    at resolveExports (node:internal/modules/cjs/loader:482:36)
    at Function.Module._findPath (node:internal/modules/cjs/loader:522:31)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:27)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/Users/pooya/Code/unctx/vitest.config.ts:37:28) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

@pi0 pi0 changed the title feat: update estree-walker to v3 chore(deps): update estree-walker to v3 Aug 3, 2022
@pi0
Copy link
Member Author

pi0 commented Aug 3, 2022

Used an ugly workaround to use esmResolve and jiti loading code.

@pi0 pi0 changed the title chore(deps): update estree-walker to v3 chore(deps)!: update estree-walker to v3 Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #23 (7dec3eb) into main (61d2007) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   77.70%   77.70%           
=======================================
  Files           2        2           
  Lines         314      314           
  Branches       56       56           
=======================================
  Hits          244      244           
  Misses         14       14           
  Partials       56       56           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 requested a review from antfu August 3, 2022 18:27
@pi0 pi0 merged commit f88439e into main Aug 3, 2022
@pi0 pi0 deleted the feat/estree-walker3 branch August 3, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants