Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(bridge): alias direct references to vue files #847

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

related to nuxt/bridge#226

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It's perhaps an abundance of caution, but we can forestall some issues with packages importing direct files within vue by adding aliases.

Mind you, it's hiding the root cause, but as the root cause is in 3rd-party libraries we'll not always be able to control this.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Oct 12, 2021
@danielroe danielroe requested a review from pi0 October 12, 2021 20:09
@danielroe danielroe self-assigned this Oct 12, 2021
@netlify
Copy link

netlify bot commented Oct 12, 2021

βœ”οΈ Deploy Preview for nuxt3-docs ready!

πŸ”¨ Explore the source changes: 6a16335

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/6165eb838298b500081431cf

😎 Browse the preview: https://deploy-preview-847--nuxt3-docs.netlify.app

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can't probably fix root cause as it is across the ecosystem...

@pi0 pi0 merged commit d5127e9 into main Oct 12, 2021
@pi0 pi0 deleted the fix/bridge-vue-aliases branch October 12, 2021 20:16
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants