Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(kit): add extendRouteRules method #9771

Merged
merged 12 commits into from Jan 21, 2023
Merged

feat(kit): add extendRouteRules method #9771

merged 12 commits into from Jan 21, 2023

Conversation

xtoolkit
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

In nuxt module develop with nuxt/kit, extendRouteRules method can be help add custom routeRules config.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Dec 17, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Dec 17, 2022

@xtoolkit is attempting to deploy a commit to the Nuxt Team on Vercel.

A member of the Team first needs to authorize it.

danielroe
danielroe suggested changes Dec 20, 2022
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we support, instead of a boolean flag as third argument, an options object with an override property?

danielroe
danielroe approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the back-and-forth. This looks good. ❤️

Would you resolve conflicts? 🙏

pi0
pi0 reviewed Dec 20, 2022
View reviewed changes
packages/kit/src/pages.ts Outdated Show resolved Hide resolved
@danielroe danielroe added enhancement New feature or request kit 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Jan 14, 2023
@xtoolkit
Merge branch 'main' of https://github.com/xtoolkit/framework into fea…
f8f1f1c 
…t-extendRotueRules

Merge branch 'main' of https://github.com/nuxt/framework into feat-extendRotueRules
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe requested a review from pi0 January 21, 2023 16:22
pi0
pi0 approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@danielroe danielroe merged commit 585e8be into nuxt:main Jan 21, 2023
@danielroe danielroe mentioned this pull request Jan 24, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manniL manniL manniL left review comments

@danielroe danielroe danielroe approved these changes

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
3.x enhancement New feature or request kit 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xtoolkit @manniL @pi0 @danielroe