Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming size to fit #16

Closed
atinux opened this issue Oct 3, 2020 · 2 comments
Closed

Renaming size to fit #16

atinux opened this issue Oct 3, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@atinux
Copy link
Member

atinux commented Oct 3, 2020

I think this makes more sense, this is the name used is providers as well as Gridsome <g-image>
@atinux atinux added the enhancement New feature or request label Oct 3, 2020
@atinux atinux changed the title feat!: Renaming size to fit Renaming size to fit Oct 3, 2020
@farnabaz
Copy link
Member

farnabaz commented Oct 3, 2020

I agree, fit is better name 👍

@pi0
Copy link
Member

pi0 commented Oct 3, 2020

I second this too 👍It is consistent with css property object-fit

procrates pushed a commit to procrates/nuxt-image that referenced this issue Feb 21, 2023
@farnabaz
fix(runtime): rename size prop to fit
fd49a83 
close nuxt#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atinux @farnabaz @pi0