Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ipx): temporarily downgrade ipx/sharp #1265

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

Aareksio
Copy link
Contributor

Downgrade ipx to 2.1.0 to avoid issues with sharp (#1257, #1210, #1237, #1253, #1262, #1264, #1228, #1227) until unjs/ipx#215 is resolved. @pi0 comment on Discord.

@danielroe danielroe requested a review from pi0 February 26, 2024 21:42
@alimozdemir
Copy link

Any news? @pi0

@pi0
Copy link
Member

pi0 commented Mar 3, 2024

(agree as hotfix, although, as asked before, with all shared links, i expected to have a minimal reproduction with clear steps and ideally only nuxt+ipx or nitro+ipx. All linked issues lack it, so whatever we do, we burry the root cause and replace it with WASM.)

@Aareksio
Copy link
Contributor Author

Aareksio commented Mar 3, 2024

Downgrading was never meant to be a long term fix. The fix is to nuxt-image, therefore the minimal reproduction is nuxt + nuxt-image. With clear steps. Run the official example. It is broken. #1257

Nuxt is in the top 5 most popular web frameworks and yet one of the most popular, official module is reported as broken for 1.5+ months. If there is no resolution to such critical issue within such timeframe, slapping the band aid, given how simple it is, seems to be a sensible short-term solution. Then we have all the time in the world to figure the root issue without hundreds of users and companies suffering.

As primarily business person, I am sometimes a bit salty about the balance between fun and maintenance in nuxt ecosystem. Conference season probably does not help 😅 I'll try to prepare plain nito + ipx reproduction tonight as requested, so you can track the exact cause. Esbuild shenanigans are beyond my comparison yet :(

@pi0
Copy link
Member

pi0 commented Mar 3, 2024

You can try on edge. I let @danielroe handle the release for the meanwhile as hotfix.

@pi0 pi0 changed the title fix(ipx): temporarily downgrade ipx to 2.1.0 fix(ipx): temporarily downgrade ipx/sharp Mar 3, 2024
@pi0 pi0 merged commit 2700ce7 into nuxt:main Mar 3, 2024
2 checks passed
@alimozdemir
Copy link

Hi @danielroe What are the plans for the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants