feat: add sanity provider #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
force-pushed
the
sanity-provider
branch
from
46f17b3
to
afad321
Compare
pi0
approved these changes
May 12, 2021
pi0
reviewed
May 12, 2021
| @@ -39,6 +39,9 @@ export default <NuxtConfig> { | |||
| imagekit: { | |||
| baseURL: 'https://ik.imagekit.io/demo' | |||
| }, | |||
| sanity: { | |||
| projectId: 'j1o4tmjp' | |||
There was a problem hiding this comment.
Sanity seems have a demo project zp7mbokg : https://www.sanity.io/docs/presenting-images
|
Merging to avoid being stalled and have basic support. It would be nice if we later investigate sanity/image-url package as well as using a sanity project that is part of their demo. |
Codecov Report
@@ Coverage Diff @@
## main #164 +/- ##
==========================================
- Coverage 57.59% 56.58% -1.01%
==========================================
Files 21 22 +1
Lines 507 516 +9
Branches 125 126 +1
==========================================
Hits 292 292
- Misses 215 224 +9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may add more options a la cloudinary module later as a separate PR later
resolves #163