feat: upgrade to unbuild@2
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
commented
Aug 28, 2023
| if (existsSync(dtsFile)) { | ||
| return | ||
| } | ||
|
|
||
| // Read generated module types | ||
| const moduleTypesFile = resolve(distDir, 'module.d.ts') | ||
| const moduleTypes = await fsp.readFile(moduleTypesFile, 'utf8').catch(() => '') | ||
| const typeExports = findExports(moduleTypes) | ||
| const typeExports = findExports( | ||
| // Replace `export { type Foo }` with `export { Foo }` |
There was a problem hiding this comment.
This is due to Swatinem/rollup-plugin-dts@1b228d0
I am uncertain if such a feature should be included in mlly as findExports is used to find non-type exports. While fineTypeExports finds types exports only. But in .d.ts actually, all exports are type exports with or without the type indicator.
|
Resolves #151 |
danielroe
approved these changes
Aug 28, 2023
Hebilicious
reviewed
Aug 28, 2023
| @@ -19,11 +19,14 @@ describe('module builder', () => { | |||
| expect(files).toMatchInlineSnapshot(` | |||
| [ | |||
| "module.cjs", | |||
| "module.d.mts", | |||
There was a problem hiding this comment.
It would be great if out the box we would generate mts and cts 🙏🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #151