Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builder): validate vue-app dependencies and suggest fix #4669

Merged
merged 5 commits into from Jan 2, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jan 2, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Background: Nuxt requires all peer like dependencies as a dependency for easier usage. Sometimes this causes unwanted behaviors when users explicitly add a specific version in their package.json which is incompatible with nuxt.

This could also help to resolve popular Vue packages version mismatch error (#198, #669, #1084, #1414, #1851, #2079, #2406, #3454) and also regressions like #4668 that vue-router@^3.0.2 is required by Nuxt and has fixes but users may encounter problems if anyhow they are still using vue-router@3.0.0.

Example error:
image

Future improvements

  • Automate dependency installs

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 added the WIP label Jan 2, 2019
@codecov-io
Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #4669 into dev will decrease coverage by 0.03%.
The diff coverage is 60.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4669      +/-   ##
==========================================
- Coverage   90.82%   90.78%   -0.04%     
==========================================
  Files          67       67              
  Lines        2223     2236      +13     
  Branches      543      545       +2     
==========================================
+ Hits         2019     2030      +11     
- Misses        185      187       +2     
  Partials       19       19
Impacted Files Coverage Δ
packages/config/src/options.js 96.21% <ø> (+2.09%) ⬆️
packages/vue-app/src/index.js 0% <0%> (ø) ⬆️
packages/builder/src/builder.js 93.53% <66.66%> (-3.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ff4058...05640a0. Read the comment docs.

@pi0 pi0 removed the WIP label Jan 2, 2019
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarkdo clarkdo merged commit 7dd33fe into dev Jan 2, 2019
@clarkdo clarkdo deleted the feat/validate-app-dependencies branch January 2, 2019 14:17
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants